Update swc by kdy1 · Pull Request #32210 · vercel/next.js

kdy1 · 2021-12-07T13:08:57Z

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

This PR upgrades all crates related to swc.

kdy1 · 2021-12-07T13:09:32Z

 pub(crate) fn contains_cjs(m: &Module) -> bool {
    let mut v = CjsFinder::default();
-    m.visit_with(&Invalid { span: DUMMY_SP }, &mut v);
+    m.visit_with(&mut v);


This is a major difference.

kdy1 · 2021-12-07T13:10:41Z

    is_global: bool,
    class_name: &Option<String>,
 ) -> Result<Expr, Error> {
+    debug!("CSS: \n{}", style_info.css);


This expression (and corresponding expression statement) will be completely noop on release builds.

cc @padmaia
It was useful for debugging to me, but I'm not sure if it's good to have this line.

I don't quite understand what it does. Doesn't seem to be spamming the terminal by default so I think I'm okay with it, but it would help to understand how it works.

We enable release_max_level_off of tracing, which is a crate for logging.
The cargo feature release_max_level_off removes all logging for release build and all macro calls for logging become completely no-op.

This logging statement will print the input passed to the css parser while testing.
testing is a crate for testing swc crates and next-swc, and it configures logger by default.

Logging level is debug by default, but if you run it like RUST_LOG=trace cargo test, trace! calls will also print the messages.

As a side note, tracing is used by swc and rustc.

kdy1 · 2021-12-07T13:13:08Z

+                            bail!("Failed to transform one off global selector");
+                        }
+
+                        trace!("Combinator: {:?}", combinator);


cc @padmaia
This line is also removable. I used it to debug styled-jsx, but I'm not sure if it's better to remove it.
Also completely noop on release builds.

Same answer as the debug comment

kdy1 · 2021-12-07T13:14:19Z

 impl VisitMut for Namespacer {
    fn visit_mut_complex_selector(&mut self, node: &mut ComplexSelector) {
+        #[cfg(debug_assertions)]
+        let _tracing = {


This block explictly uses #[cfg(debug_assertions)] because it does some operation which cannot removed by tracing.

kdy1 · 2021-12-07T13:16:05Z

      <Element {...props} className={"jsx-abb4c2202db1a207" + " " + (props && props.className != null && props.className || "")}/>
-      <_JSXStyle id={"abb4c2202db1a207"}>{"div.jsx-abb4c2202db1a207 {color:red}"}</_JSXStyle>
+
+      <_JSXStyle id={"abb4c2202db1a207"}>{"div.jsx-abb4c2202db1a207{color:red}"}</_JSXStyle>


I removed a space between the selectors and the block.
Most css changes of this PR is due to removal of the space.

padmaia · 2021-12-07T23:16:35Z

    is_global: bool,
    class_name: &Option<String>,
 ) -> Result<Expr, Error> {
+    debug!("CSS: \n{}", style_info.css);


I don't quite understand what it does. Doesn't seem to be spamming the terminal by default so I think I'm okay with it, but it would help to understand how it works.

padmaia · 2021-12-08T00:33:22Z

+                            bail!("Failed to transform one off global selector");
+                        }
+
+                        trace!("Combinator: {:?}", combinator);


Same answer as the debug comment

ijjk · 2021-12-08T11:08:25Z

Failing test suites

Commit: 34ad44b

test/integration/app-document-add-hmr/test/index.test.js

_app/_document add HMR > should HMR when _document is added

Expand output

● _app/_document add HMR › should HMR when _document is added

expect(received).toContain(expected) // indexOf

Expected substring: "index page"
Received string:    "<head><meta charset=\"utf-8\"><meta name=\"viewport\" content=\"width=device-width\"><meta name=\"next-head-count\" content=\"2\"><noscript data-n-css=\"\"></noscript><script defer=\"\" nomodule=\"\" src=\"/_next/static/chunks/polyfills.js?ts=1638961696667\"></script><script src=\"/_next/static/chunks/fallback/webpack.js?ts=1638961696667\" defer=\"\"></script><script src=\"/_next/static/chunks/fallback/main.js?ts=1638961696667\" defer=\"\"></script><script src=\"/_next/static/chunks/fallback/pages/_app.js?ts=1638961696667\" defer=\"\"></script><script src=\"/_next/static/chunks/fallback/pages/_error.js?ts=1638961696667\" defer=\"\"></script><noscript id=\"__next_css__DO_NOT_USE__\"></noscript></head><body style=\"overflow: hidden;\"><div id=\"__next\" data-reactroot=\"\"></div><script src=\"/_next/static/chunks/fallback/react-refresh.js?ts=1638961696667\"></script><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"statusCode\":500}},\"page\":\"/_error\",\"query\":{},\"buildId\":\"development\",\"isFallback\":false,\"err\":{\"name\":\"ModuleBuildError\",\"message\":\"Module build failed (from ../../../packages/next/dist/build/webpack/loaders/next-swc-loader.js):\\nError: Failed to read source code from /home/runner/work/next.js/next.js/test/integration/app-document-add-hmr/pages/_app.js\\n\\nCaused by:\\n    No such file or directory (os error 2)\",\"stack\":\"ModuleBuildError: Module build failed (from ../../../packages/next/dist/build/webpack/loaders/next-swc-loader.js):\\nError: Failed to read source code from /home/runner/work/next.js/next.js/test/integration/app-document-add-hmr/pages/_app.js\\n\\nCaused by:\\n    No such file or directory (os error 2)\\n    at processResult (/home/runner/work/next.js/next.js/packages/next/dist/compiled/webpack/bundle5.js:54691:19)\\n    at /home/runner/work/next.js/next.js/packages/next/dist/compiled/webpack/bundle5.js:54793:5\\n    at /home/runner/work/next.js/next.js/packages/next/dist/compiled/webpack/bundle5.js:140664:11\\n    at /home/runner/work/next.js/next.js/packages/next/dist/compiled/webpack/bundle5.js:140460:20\\n    at context.callback (/home/runner/work/next.js/next.js/packages/next/dist/compiled/webpack/bundle5.js:140389:13)\"},\"gip\":true,\"scriptLoader\":[]}</script><div id=\"__next-build-watcher\" style=\"position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;\"></div><next-route-announcer><p aria-live=\"assertive\" id=\"__next-route-announcer__\" role=\"alert\" style=\"border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; width: 1px; white-space: nowrap; overflow-wrap: normal;\"></p></next-route-announcer><nextjs-portal></nextjs-portal></body>"

  54 |       await fs.remove(appPage)
  55 |     }
> 56 |   })
     |     ^
  57 |
  58 |   it('should HMR when _document is added', async () => {
  59 |     let indexContent = await fs.readFile(indexPage)

  at Object.<anonymous> (integration/app-document-add-hmr/test/index.test.js:56:27)

test/integration/css-customization/test/index.test.js

CSS Customization custom loader > should've applied style

Expand output

● CSS Customization custom loader › should've applied style

expect(received).toMatch(expected)

Expected pattern: /\.my-text\.jsx-[0-9a-z]+ {color:red}/
Received string:  "(self.webpackChunk_N_E=self.webpackChunk_N_E||[]).push([[405],{3797:function(n,t,e){\"use strict\";t.default=c;var u,r=(u=e(1902))&&u.__esModule?u:{default:u},f=e(9684),a=e(2052);var i=r.default.useInsertionEffect||r.default.useLayoutEffect;function c(n){var t=(0,f.useStyleRegistry)();return t?\"undefined\"===typeof window?(t.add(n),null):(i((function(){return t.add(n),function(){t.remove(n)}}),[n.id,String(n.dynamic)]),null):null}c.dynamic=function(n){return n.map((function(n){var t=n[0],e=n[1];return(0,a.computeId)(t,e)})).join(\" \")}},9424:function(n,t,e){n.exports=e(3797)},9461:function(n,t,e){(window.__NEXT_P=window.__NEXT_P||[]).push([\"/\",function(){return e(6343)}])},6343:function(n,t,e){\"use strict\";e.r(t),e.d(t,{default:function(){return i}});var u=e(3704),r=e(9424),f=new String(\".my-text.jsx-ff6a1f25a3b55a1f{color:red}\");f.__hash=\"ff6a1f25a3b55a1f\";var a=f;function i(){return(0,u.jsxs)(u.Fragment,{children:[(0,u.jsx)(\"div\",{className:\"jsx-\".concat(a.__hash)+\" my-text\",children:\"This text should be red.\"}),(0,u.jsx)(r.default,{id:a.__hash,children:a})]})}}},function(n){n.O(0,[774,888,179],(function(){return t=9461,n(n.s=t);var t}));var t=n.O();_N_E=t}]);"

  148 |   beforeAll(async () => {
  149 |     await remove(join(appDir, '.next'))
> 150 |   })
      |     ^
  151 |
  152 |   it('should compile successfully', async () => {
  153 |     const { code, stdout, stderr } = await nextBuild(appDir, [], {

  at Object.<anonymous> (integration/css-customization/test/index.test.js:150:30)

ijjk · 2021-12-08T12:02:46Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	kdy1/next.js update-swc-min	Change
buildDuration	18.4s	18.1s	-218ms
buildDurationCached	3.4s	3.3s	-143ms
nodeModulesSize	349 MB	349 MB	⚠️ +7 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	kdy1/next.js update-swc-min	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.953	2.973	⚠️ +0.02
/ avg req/sec	846.73	840.92	⚠️ -5.81
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.397	1.399	0
/error-in-render avg req/sec	1790.14	1786.69	⚠️ -3.45

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kdy1/next.js update-swc-min	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.8 kB	28.8 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.7 kB	72.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kdy1/next.js update-swc-min	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kdy1/next.js update-swc-min	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.39 kB	2.39 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	4.73 kB	4.73 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.13 kB	2.13 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	kdy1/next.js update-swc-min	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	kdy1/next.js update-swc-min	Change
index.html gzip	532 B	532 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	kdy1/next.js update-swc-min	Change
buildDuration	18.5s	18.8s	⚠️ +339ms
buildDurationCached	3.3s	3.3s	⚠️ +32ms
nodeModulesSize	349 MB	349 MB	⚠️ +7 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	kdy1/next.js update-swc-min	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.795	2.841	⚠️ +0.05
/ avg req/sec	894.42	879.86	⚠️ -14.56
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.347	1.373	⚠️ +0.03
/error-in-render avg req/sec	1856.66	1820.77	⚠️ -35.89

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kdy1/next.js update-swc-min	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	29.1 kB	29.1 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	73 kB	73 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kdy1/next.js update-swc-min	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kdy1/next.js update-swc-min	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.39 kB	2.39 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	906 B	906 B	✓
image-HASH.js gzip	4.75 kB	4.75 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.19 kB	2.19 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	kdy1/next.js update-swc-min	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	kdy1/next.js update-swc-min	Change
index.html gzip	531 B	531 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: 5e3ef5b

Fixes failing tests from swc bump in #32210 which removed some whitespace. x-ref: https://github.com/vercel/next.js/runs/4456734159?check_suite_focus=true x-ref: https://github.com/vercel/next.js/runs/4461064714?check_suite_focus=true

kdy1 added 30 commits December 7, 2021 17:56

Update crates

9991358

Update deps

2232a50

Fix js handler

f0d6e40

Update code for js

2f54305

DEBUG

c76cc38

Fix index

2284654

Prevent panic

d52f3e3

Skip some spaces

65d6d09

Log

f8cdf22

More fix

c8fb5ec

Logging

c08a40d

Remove dbg!

7c67c3a

Fix prefixer

2f152a8

Remove wrong logic

6d57e20

Update test refs (hygiene)

3f9a734

Update swc

acb8e8c

Update test refs

99c6afc

Update test refs

5395085

Update test refs

218e13c

Update test refs

77d9fe3

Update test refs

a16a1dd

Update test refs

68b0957

Update test refs

2bc25fc

Update test refs

ac8e874

Update test refs

6b62d48

Remove hack for prefixer

9b9c4f3

Update test refs

b31c9c1

Update test refs

7c8a678

Update test refs

7defcf1

Better logging

7c8defa

kdy1 requested review from huozhi, ijjk, shuding and timneutkens as code owners December 7, 2021 13:08

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 7, 2021

kdy1 commented Dec 7, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

padmaia self-requested a review December 7, 2021 23:01

padmaia previously approved these changes Dec 8, 2021

View reviewed changes

Update swc

964bbe4

kdy1 dismissed padmaia’s stale review via 964bbe4 December 8, 2021 06:07

kdy1 added 2 commits December 8, 2021 15:17

Update test refs

e47af03

Merge branch 'canary' into update-swc-min

885b49a

This comment has been minimized.

Sign in to view

kdy1 added 2 commits December 8, 2021 19:50

Update swc_ecma_transforms_compat

6ca31c6

Merge branch 'canary' into update-swc-min

34ad44b

This comment has been minimized.

Sign in to view

Fix test whitespace

5e3ef5b

padmaia approved these changes Dec 8, 2021

View reviewed changes

timneutkens merged commit 4ce49b7 into vercel:canary Dec 8, 2021

timneutkens deleted the update-swc-min branch December 8, 2021 17:54

ijjk mentioned this pull request Dec 8, 2021

Fix styled-jsx tests from swc bump #32297

Merged

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

kdy1 self-assigned this Oct 23, 2024

Uh oh!

Conversation

kdy1 commented Dec 7, 2021

Bug

Feature

Documentation / Examples

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

ijjk commented Dec 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failing test suites

Uh oh!

This comment has been minimized.

ijjk commented Dec 8, 2021

Stats from current PR

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ijjk commented Dec 8, 2021 •

edited

Loading