imgmath: Fix embed mode#10878
Merged
Merged
Conversation
AA-Turner
approved these changes
Sep 28, 2022
AA-Turner
left a comment
Member
There was a problem hiding this comment.
Should we clean up the test files properly rather than rearranging the order? Approved other than that.
A
a4389a9 to
8d85a7e
Compare
We incorrectly used leftover files from previous tests in the destination folder instead of the temporary file we just generated.
8d85a7e to
edab3c6
Compare
Contributor
Author
|
yes, I cleaned up the first few output directories instead, but perhaps it could be done more globally in a separate PR |
Member
|
I'm trying to get the CircleCI integration to show up... |
Contributor
Author
|
is there a 5.2.3 planned ? |
Member
|
Sphinx 5.2.3 has been released. A |
Contributor
Author
|
thanks a lot! |
marxin
pushed a commit
to marxin/sphinx
that referenced
this pull request
Oct 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We incorrectly used the destination file instead of the temporary just generated.
The test incorrectly succeeded because of leftover files from previous tests, so moved that test first.
fixes #10816, directed to the 5.2.x branch hoping it would land into the next patch version if any