Fix case where shows no content found for no data

akashnairrr · akashnairrr · commit 72cd0855e1ac · 2026-04-14T17:12:05.000+05:30
diff --git a/tests/test_invalid_html.py b/tests/test_invalid_html.py
@@ -96,7 +96,8 @@ def test_dynamic_table_does_not_render_header_fallback_without_rows(self):
 
         rendered_html = self.doc.render(data)
 
-        assert "<th" not in rendered_html, "Header fallback should not render without rows"
+        assert rendered_html.strip() == "No content found", "Empty tables should render only plain text"
+        assert "<table" not in rendered_html, "Empty tables should not render any table markup"
         assert "Created At" not in rendered_html, "Hidden empty columns should not leak into output"
 
     def test_dynamic_table_security(self):
diff --git a/tiptapy/templates/dynamicTable.html b/tiptapy/templates/dynamicTable.html
@@ -1,13 +1,16 @@
+{%- set visible_columns = [] -%}
+{%- set rows = node.attrs.content.rows if node.attrs.content and node.attrs.content.rows else [] -%}
+{%- if rows|length == 0 -%}
+No content found
+{%- else -%}
 <table>
-    {%- set visible_columns = [] -%}
     {%- if node.attrs.columns and node.attrs.columns|length > 0 -%}
     {%- for header, props in node.attrs.columns.items() -%}
     {%- if props.visible -%}
     {%- set _ = visible_columns.append((header, props)) -%}
     {%- endif -%}
     {%- endfor -%}
-    {%- elif node.attrs.content and node.attrs.content.headers and node.attrs.content.rows and
-    node.attrs.content.rows|length > 0 -%}
+    {%- elif node.attrs.content and node.attrs.content.headers -%}
     {%- for header in node.attrs.content.headers -%}
     {%- set _ = visible_columns.append((header, {"originalName": header, "alias": None, "visible": True, "order":
     loop.index0, "width": None})) -%}
@@ -31,7 +34,7 @@
         </tr>
     </thead>
     <tbody>
-        {%- for row in node.attrs.content.rows -%}
+        {%- for row in rows -%}
         <tr>
             {%- for header, props in visible_columns|sort(attribute='1.order') -%}
             {%- if header in node.attrs.content.headers -%}
@@ -53,3 +56,4 @@
         {%- endfor -%}
     </tbody>
 </table>
+{%- endif -%}
diff --git a/tiptapy/templates/dynamic_table.html b/tiptapy/templates/dynamic_table.html
@@ -1,13 +1,16 @@
+{%- set visible_columns = [] -%}
+{%- set rows = node.attrs.content.rows if node.attrs.content and node.attrs.content.rows else [] -%}
+{%- if rows|length == 0 -%}
+No content found
+{%- else -%}
 <table>
-    {%- set visible_columns = [] -%}
     {%- if node.attrs.columns and node.attrs.columns|length > 0 -%}
     {%- for header, props in node.attrs.columns.items() -%}
     {%- if props.visible -%}
     {%- set _ = visible_columns.append((header, props)) -%}
     {%- endif -%}
     {%- endfor -%}
-    {%- elif node.attrs.content and node.attrs.content.headers and node.attrs.content.rows and
-    node.attrs.content.rows|length > 0 -%}
+    {%- elif node.attrs.content and node.attrs.content.headers -%}
     {%- for header in node.attrs.content.headers -%}
     {%- set _ = visible_columns.append((header, {"originalName": header, "alias": None, "visible": True, "order":
     loop.index0, "width": None})) -%}
@@ -31,7 +34,7 @@
         </tr>
     </thead>
     <tbody>
-        {%- for row in node.attrs.content.rows -%}
+        {%- for row in rows -%}
         <tr>
             {%- for header, props in visible_columns|sort(attribute='1.order') -%}
             {%- if header in node.attrs.content.headers -%}
@@ -53,3 +56,4 @@
         {%- endfor -%}
     </tbody>
 </table>
+{%- endif -%}
