[react] Add support for legacy context in class components in JSXElementConstructor

NMinhNguyen · NMinhNguyen · commit 8bb235b618eb · 2023-07-06T10:44:27.000+01:00
diff --git a/types/react/index.d.ts b/types/react/index.d.ts
@@ -83,7 +83,13 @@ declare namespace React {
                */
               deprecatedLegacyContext?: any,
           ) => ReactNode)
-        | (new (props: P) => Component<any, any>);
+        | (new (
+              props: P,
+              /**
+               * @deprecated https://legacy.reactjs.org/docs/legacy-context.html#referencing-context-in-lifecycle-methods
+               */
+              deprecatedLegacyContext?: any,
+          ) => Component<any, any>);
 
     interface RefObject<T> {
         readonly current: T | null;
diff --git a/types/react/test/index.ts b/types/react/test/index.ts
@@ -810,6 +810,11 @@ const propsWithoutRef: React.PropsWithoutRef<UnionProps> = {
         return null;
     };
     Wrapper = (props, legacyContext: { foo: number }) => null;
+    Wrapper = class Exact extends React.Component<ExactProps> {
+        constructor(props: ExactProps, legacyContext: { foo: number }) {
+            super(props, legacyContext);
+        }
+    };
 
     React.createElement(Wrapper, { value: 'A' });
     React.createElement(Wrapper, { value: 'B' });
diff --git a/types/react/test/tsx.tsx b/types/react/test/tsx.tsx
@@ -357,6 +357,22 @@ class LegacyContext extends React.Component {
     }
 }
 
+class LegacyContextWithConstructor extends React.Component {
+    static contextTypes = { foo: PropTypes.node.isRequired };
+
+    constructor(props: {}, context: {}) {
+        super(props, context);
+    }
+
+    render() {
+        // $ExpectType unknown
+        this.context;
+        return (this.context as any).foo;
+    }
+}
+
+<LegacyContextWithConstructor />;
+
 class LegacyContextAnnotated extends React.Component {
     static contextTypes = { foo: PropTypes.node.isRequired };
     context: { foo: React.ReactNode } = { foo: {} as React.ReactNode };
diff --git a/types/react/ts5.0/index.d.ts b/types/react/ts5.0/index.d.ts
@@ -51,7 +51,13 @@ declare namespace React {
                */
               deprecatedLegacyContext?: any,
           ) => ReactElement<any, any> | null)
-        | (new (props: P) => Component<any, any>);
+        | (new (
+              props: P,
+              /**
+               * @deprecated https://legacy.reactjs.org/docs/legacy-context.html#referencing-context-in-lifecycle-methods
+               */
+              deprecatedLegacyContext?: any,
+          ) => Component<any, any>);
 
     interface RefObject<T> {
         readonly current: T | null;
diff --git a/types/react/ts5.0/test/index.ts b/types/react/ts5.0/test/index.ts
@@ -818,6 +818,11 @@ const propsWithoutRef: React.PropsWithoutRef<UnionProps> = {
         return null;
     };
     Wrapper = (props, legacyContext: { foo: number }) => null;
+    Wrapper = class Exact extends React.Component<ExactProps> {
+        constructor(props: ExactProps, legacyContext: { foo: number }) {
+            super(props, legacyContext);
+        }
+    };
 
     React.createElement(Wrapper, { value: 'A' });
     React.createElement(Wrapper, { value: 'B' });
diff --git a/types/react/ts5.0/test/tsx.tsx b/types/react/ts5.0/test/tsx.tsx
@@ -357,6 +357,22 @@ class LegacyContext extends React.Component {
     }
 }
 
+class LegacyContextWithConstructor extends React.Component {
+    static contextTypes = { foo: PropTypes.node.isRequired };
+
+    constructor(props: {}, context: {}) {
+        super(props, context);
+    }
+
+    render() {
+        // $ExpectType unknown
+        this.context;
+        return (this.context as any).foo;
+    }
+}
+
+<LegacyContextWithConstructor />;
+
 class LegacyContextAnnotated extends React.Component {
     static contextTypes = { foo: PropTypes.node.isRequired };
     context: { foo: React.ReactNode } = { foo: {} as React.ReactNode };
