fix: Remove source/target conn from JSON config file#1739
Merged
nj1973 merged 3 commits intoMay 21, 2026
Conversation
Collaborator
Author
|
/gcbrun |
sundar-mudupalli-work
approved these changes
May 21, 2026
sundar-mudupalli-work
left a comment
Collaborator
There was a problem hiding this comment.
Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
In
data_validation/__main__.pywe used to add the raw connection info into the JSON. The PR removes that code and adds a test to ensure that the resulting JSON executes correctly (i.e. the fields were not required).Issues to be closed
Closes #1738
Checklist
CONTRIBUTINGGuide.tests/local_check.shscript)