Skip to content

fix: Remove source/target conn from JSON config file#1739

Merged
nj1973 merged 3 commits into
developfrom
1738-connection-handling-for-yaml-and-json-config-files
May 21, 2026
Merged

fix: Remove source/target conn from JSON config file#1739
nj1973 merged 3 commits into
developfrom
1738-connection-handling-for-yaml-and-json-config-files

Conversation

@nj1973

@nj1973 nj1973 commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Description of changes

In data_validation/__main__.py we used to add the raw connection info into the JSON. The PR removes that code and adds a test to ensure that the resulting JSON executes correctly (i.e. the fields were not required).

Issues to be closed

Closes #1738

Checklist

  • I have followed the CONTRIBUTING Guide.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated any relevant documentation to reflect my changes, if applicable
  • I have added unit and/or integration tests relevant to my change as needed
  • I have already checked locally that all unit tests and linting are passing (use the tests/local_check.sh script)
  • I have manually executed end-to-end testing (E2E) with the affected databases/engines

@nj1973

nj1973 commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

/gcbrun

@sundar-mudupalli-work sundar-mudupalli-work left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@nj1973 nj1973 merged commit 76d797d into develop May 21, 2026
10 checks passed
@nj1973 nj1973 deleted the 1738-connection-handling-for-yaml-and-json-config-files branch May 21, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent connection name handling for YAML and JSON config files

2 participants