using SafeERC20 to implement safeTransfer in Crowdsale#1006
Merged
frangio merged 3 commits intoJun 16, 2018
Merged
Conversation
2 tasks
frangio
reviewed
Jun 13, 2018
frangio
left a comment
Contributor
There was a problem hiding this comment.
LGTM save for one unnecessary input. Thank you @dougiebuckets!
|
|
||
| import "../token/ERC20/ERC20.sol"; | ||
| import "../math/SafeMath.sol"; | ||
| import "../token/ERC20/ERC20Basic.sol"; |
Contributor
There was a problem hiding this comment.
This new import is not necessary.
come-maiz
approved these changes
Jun 15, 2018
come-maiz
left a comment
There was a problem hiding this comment.
Thank you! Leaving my +1 too, but we'll wait for you to remove the import before merging.
c3f1c73 to
bd6241a
Compare
bd6241a to
6c4ef3d
Compare
|
One more thing @dougiebuckets. There is a file .node-xmlhttprequest-sync-7601, can you please remove it? |
Contributor
Author
|
Good catch, @ElOpio. Thank you. Update made. |
Contributor
|
Thanks @dougiebuckets! |
nventuro
pushed a commit
to nventuro/openzeppelin-contracts
that referenced
this pull request
Jun 18, 2018
…1006) * introduced safeTransfer to Crowdsale * Removed .node-xmlhttprequest-sync-7601
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #985
🚀 Description
Introduced safeTransfer to Crowdsale. Opened new pull request b/c I accidently closed this one: #985
npm run lint:all:fix).