ECRecover test should revert because of wrong calldata size#1050
Merged
Conversation
shrugs
approved these changes
Jul 10, 2018
Contributor
|
closes #1034 as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Description
This is a change for Solidity 0.5.0, see argotorg/solidity#4224
This test should now revert because the first argument is
bytes32but fewer bytes are sent.One point I wanted to ask is whether more tests regarding that are wanted/needed, especially for the second argument (
bytes), for example: too short data, too long padded correct data, correct length but invalid data.Please not that only the latest commit is relevant for this PR.
closes #1034