Skip to content

Made remaining public fallback functions external#1080

Merged
nventuro merged 1 commit into
OpenZeppelin:masterfrom
dougiebuckets:make-fallback-functions-external-#1075
Jul 20, 2018
Merged

Made remaining public fallback functions external#1080
nventuro merged 1 commit into
OpenZeppelin:masterfrom
dougiebuckets:make-fallback-functions-external-#1075

Conversation

@dougiebuckets

Copy link
Copy Markdown
Contributor

Fixes #1075

🚀 Description

Made remaining public fallback functions external per #1075

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • ✅ I've run all tests; everything looks good
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

@nventuro nventuro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay compilation now passes! The ECRecovery test errored out though, I'll look into that.

@nventuro

Copy link
Copy Markdown
Contributor

Thanks @dougiebuckets!

@nventuro nventuro merged commit ce0c327 into OpenZeppelin:master Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make fallback functions external for Solidity 0.5.0

2 participants