Remove chai-as-promised#1116
Conversation
There was a problem hiding this comment.
This is awesome, thank you very much @justuswilhelm!
If you're into testing, there's a couple more easy issues that need love: two bugfixes (#775 and #938) and two features (#917 and #942). We plan on exporting our testing helpers soon for users of the library (#326), so these will be super helpful.
Thanks again!
| 'Expected \'' + message + '\', got \'' + error + '\' instead', | ||
| ); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Could you change this brace for an else, to emphasize the fact that the message parameter changes the usual behavior?
There was a problem hiding this comment.
Yes, absolutely. Let me fix that.
|
Thanks for pointing out some other issues I can work on, @nventuro . And yes, I do enjoy working on test code! 👍 |
|
Great, thanks! By the way, we do squash merges, so there's no need to rebase your branch when addressing reviews. Not doing that actually makes our job easier, since we can easily see what changed from review to review :) |
|
@nventuro Much appreciated! Re. the squashing, noted! |
Addresses #1091 -- it's about @nventuro's comment about removing
chai-as-promised🚀 Description
I'm doing a few things here:
invalid opcodeawaitand be done, or I useexpectThrowand test for a specific exception messagenpm run lint:all:fix).