Skip to content

Added address of pauser/unpauser in events#1410

Merged
nventuro merged 2 commits into
OpenZeppelin:masterfrom
Glisch:improve-pausable-events-#1393
Oct 18, 2018
Merged

Added address of pauser/unpauser in events#1410
nventuro merged 2 commits into
OpenZeppelin:masterfrom
Glisch:improve-pausable-events-#1393

Conversation

@Glisch

@Glisch Glisch commented Oct 12, 2018

Copy link
Copy Markdown
Contributor

Fixes #1393

Added address of the caller for Paused and Unpaused events in Pausable.sol

@nventuro nventuro self-assigned this Oct 12, 2018
@nventuro nventuro added this to the v2.0 milestone Oct 12, 2018
@nventuro

Copy link
Copy Markdown
Contributor

Great @Glisch, thanks for contributing to OpenZeppelin!

Could you also add this address when checking the events in the Pausable tests?

@Glisch

Glisch commented Oct 12, 2018

Copy link
Copy Markdown
Contributor Author

Oops, sure thing.

@nventuro

Copy link
Copy Markdown
Contributor

Sorry to push directly to your branch @Glisch, but we're planning on wrapping up the 2.0 release for tomorrow morning, and need to get this in before then. Thanks a lot for your help!

@nventuro nventuro requested a review from come-maiz October 17, 2018 21:22

@come-maiz come-maiz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Glisch and @nventuro! <3

@nventuro nventuro merged commit fcab9c8 into OpenZeppelin:master Oct 18, 2018
come-maiz pushed a commit that referenced this pull request Oct 21, 2018
* Added address of pauser/unpauser in events

* Added the account to the Pausable tests.

(cherry picked from commit fcab9c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Pausable events

3 participants