Internal crowdsales#1439
Merged
Merged
Conversation
come-maiz
approved these changes
Oct 18, 2018
come-maiz
left a comment
There was a problem hiding this comment.
I agree with the internals.
About the view additions, can you overrride a view function with a non-view function? I guess it would be even better if you can't because the validation functions should have no side-effects, and this would prevent people from doing crazy things. But it would have been nice this topic analyzed in a separate issue ;)
Contributor
Author
|
As far as I know you can't, which is sort of the idea :) |
come-maiz
pushed a commit
that referenced
this pull request
Oct 21, 2018
* Made some internal crowdsale methods internal. * Made all Crowdsale constructors internal. (cherry picked from commit d9fdffe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1394, crowdsales are always extended (because the base contract remains abstract).