Make contracts 4.24 compatible#951
Conversation
come-maiz
left a comment
There was a problem hiding this comment.
Awesome @artiebits, thanks a lot. We usually wait around a month after solc is released to update, so this will be perfect for our next release.
However, because we were slow to review this now it has some conflicts. Can you please rebase?
Also, please update the truffle version.
| "solidity-coverage": "^0.5.0", | ||
| "solium": "^1.1.7", | ||
| "truffle": "^4.1.8", | ||
| "truffle": "^4.1.9", |
There was a problem hiding this comment.
This should be 4.1.11:
https://github.com/trufflesuite/truffle/releases/tag/v4.1.11
|
@ElOpio np, rebased and updated |
|
Sorry @artiebits, once more. |
|
oops we did it again 😓 I'll personally avoid merging any more PRs until this one is merged. sorry for the extra work, @artiebits |
|
Any chance merging this and #1002? It would simplify our life at the Solidity repo a lot :) |
|
@axic will do! |
|
Also it'd be cool if these sort of upgrades were done automatically by a bot in the future, since it's a pretty easily automatable (but human-checkable) operation |
|
Btw, people with write access to this repo should be able (unless specifically disabled by the owner) to push to @artiebits PRs. |
|
no worries, updated |
This should be possible using Solium's fix mode! |
shrugs
left a comment
There was a problem hiding this comment.
a quick search for 0.4.23 in the project shows no missing pragmas, so we're good to go
|
🚀 Description
npm run lint:all:fix).Truffle updated solc to 0.4.24 as well.
Warnings fixed:
keccak256only accepts a single "bytes" argument.