NFC: Use genMnemonicAlias instead of extraClassDeclarations for getAlias

asraa · copybara-github · commit c7f2e60cbd4a · 2026-05-18T10:12:55.000-07:00
llvm/llvm-project#121187 PiperOrigin-RevId: 917297488
diff --git a/lib/Dialect/LWE/IR/LWEAttributes.td b/lib/Dialect/LWE/IR/LWEAttributes.td
@@ -43,17 +43,10 @@ def AnyOverflowAttr : AnyAttrOf<[LWE_NoOverflowAttr, LWE_PreserveOverflowAttr]>
 }
 
 class LWE_EncodingAttrForLWE<string attrName, string attrMnemonic, list<Trait> traits = []>
-    : AttrDef<LWE_Dialect, attrName, traits # [OpAsmAttrInterface]> {
+    : AttrDef<LWE_Dialect, attrName, traits> {
   let mnemonic = attrMnemonic;
   let assemblyFormat = "`<` struct(params) `>`";
-
-  let extraClassDeclaration = [{
-    // OpAsmAttrInterface methods.
-    ::mlir::OpAsmDialectInterface::AliasResult getAlias(::llvm::raw_ostream &os) const {
-      os << "}] # attrMnemonic # [{";
-      return ::mlir::OpAsmDialectInterface::AliasResult::FinalAlias;
-    }
-  }];
+  let genMnemonicAlias = 1;
 }
 
 class LWE_EncodingAttrWithScalingParam<string attrName, string attrMnemonic, list<Trait> traits = []>
@@ -237,7 +230,7 @@ def LWE_PlaintextSpaceAttr : AttrDef<LWE_Dialect, "PlaintextSpace"> {
   let genVerifyDecl = 1;
 }
 
-def LWE_KeyAttr : AttrDef<LWE_Dialect, "Key", [OpAsmAttrInterface]> {
+def LWE_KeyAttr : AttrDef<LWE_Dialect, "Key"> {
   let mnemonic = "key";
   let description = [{
     An attribute describing the key with which the message is currently
@@ -260,14 +253,7 @@ def LWE_KeyAttr : AttrDef<LWE_Dialect, "Key", [OpAsmAttrInterface]> {
   );
 
   let assemblyFormat = "`<` struct(params) `>`";
-
-  let extraClassDeclaration = [{
-    // OpAsmAttrInterface methods.
-    ::mlir::OpAsmDialectInterface::AliasResult getAlias(::llvm::raw_ostream &os) const {
-      os << "}] # mnemonic # [{";
-      return ::mlir::OpAsmDialectInterface::AliasResult::FinalAlias;
-    }
-  }];
+  let genMnemonicAlias = 1;
 }
 
 def LWE_EncryptionTypeEnum : I32EnumAttr<"LweEncryptionType", "An enum attribute representing an encryption method", [
diff --git a/lib/Dialect/Rotom/IR/RotomAttributes.td b/lib/Dialect/Rotom/IR/RotomAttributes.td
@@ -8,17 +8,10 @@ include "mlir/IR/CommonAttrConstraints.td"
 include "mlir/IR/OpAsmInterface.td"
 
 class Rotom_Attr<string name, string attrMnemonic, list<Trait> traits = []>
-    : AttrDef<Rotom_Dialect, name, traits # [OpAsmAttrInterface]> {
+    : AttrDef<Rotom_Dialect, name, traits> {
   let mnemonic = attrMnemonic;
   let assemblyFormat = "`<` struct(params) `>`";
-
-  let extraClassDeclaration = [{
-    // OpAsmAttrInterface methods.
-    ::mlir::OpAsmDialectInterface::AliasResult getAlias(::llvm::raw_ostream &os) const {
-      os << "}] # attrMnemonic # [{";
-      return ::mlir::OpAsmDialectInterface::AliasResult::FinalAlias;
-    }
-  }];
+  let genMnemonicAlias = 1;
 }
 
 def Rotom_DimAttr : Rotom_Attr<"Dim", "dim"> {
diff --git a/lib/Dialect/Secret/IR/SecretAttributes.td b/lib/Dialect/Secret/IR/SecretAttributes.td
@@ -8,17 +8,10 @@ include "mlir/IR/CommonAttrConstraints.td"
 include "mlir/IR/OpAsmInterface.td"
 
 class Secret_Attr<string name, string attrMnemonic, list<Trait> traits = []>
-    : AttrDef<Secret_Dialect, name, traits # [OpAsmAttrInterface]> {
+    : AttrDef<Secret_Dialect, name, traits> {
   let mnemonic = attrMnemonic;
   let assemblyFormat = "`<` struct(params) `>`";
-
-  let extraClassDeclaration = [{
-    // OpAsmAttrInterface methods.
-    ::mlir::OpAsmDialectInterface::AliasResult getAlias(::llvm::raw_ostream &os) const {
-      os << "}] # attrMnemonic # [{";
-      return ::mlir::OpAsmDialectInterface::AliasResult::FinalAlias;
-    }
-  }];
+  let genMnemonicAlias = 1;
 }
 
 def Secret_KernelAttr : Secret_Attr<"Kernel", "kernel"> {
diff --git a/lib/Dialect/TensorExt/IR/TensorExtAttributes.td b/lib/Dialect/TensorExt/IR/TensorExtAttributes.td
@@ -10,20 +10,10 @@ include "mlir/IR/OpAsmInterface.td"
 include "mlir/IR/TensorEncoding.td"
 
 class TensorExt_Attr<string name, string attrMnemonic, list<Trait> traits = []>
-    : AttrDef<TensorExt_Dialect, name, traits # [OpAsmAttrInterface]> {
+    : AttrDef<TensorExt_Dialect, name, traits> {
   let mnemonic = attrMnemonic;
   let assemblyFormat = "`<` struct(params) `>`";
-
-  string commonClassDeclaration = [{
-   // OpAsmAttrInterface methods.
-    ::mlir::OpAsmDialectInterface::AliasResult getAlias(::llvm::raw_ostream &os) const {
-      os << "}] # attrMnemonic # [{";
-      return ::mlir::OpAsmDialectInterface::AliasResult::FinalAlias;
-    }
-  }];
-
-
-  let extraClassDeclaration = commonClassDeclaration;
+  let genMnemonicAlias = 1;
 }
 
 def TensorExt_LayoutAttr : TensorExt_Attr<"Layout", "layout"> {
@@ -64,7 +54,7 @@ def TensorExt_LayoutAttr : TensorExt_Attr<"Layout", "layout"> {
     }]>,
   ];
 
-  let extraClassDeclaration = commonClassDeclaration # [{
+  let extraClassDeclaration = [{
     presburger::IntegerRelation getIntegerRelation() const;
 
     std::string getLayoutStr() const {
