Skip to content

[LBSE] Improve filter rendering#66880

Draft
rwlbuis wants to merge 1 commit into
WebKit:mainfrom
rwlbuis:eng/LBSE-Improve-filter-rendering
Draft

[LBSE] Improve filter rendering#66880
rwlbuis wants to merge 1 commit into
WebKit:mainfrom
rwlbuis:eng/LBSE-Improve-filter-rendering

Conversation

@rwlbuis

@rwlbuis rwlbuis commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

8b1fc5b

[LBSE] Improve filter rendering
https://bugs.webkit.org/show_bug.cgi?id=316788

WIP.

Reviewed by NOBODY (OOPS!).

Explanation of why this fixes the bug (OOPS!).

* LayoutTests/platform/mac-tahoe-wk2-lbse-text/TestExpectations:
* Source/WebCore/platform/graphics/filters/Filter.h:
* Source/WebCore/rendering/CSSFilterRenderer.cpp:
(WebCore::CSSFilterRenderer::create):
(WebCore::createReferenceFilter):
(WebCore::CSSFilterRenderer::expandFilterRegionForSVGReferences):
(WebCore::CSSFilterRenderer::computeEnclosingFilterRegion):
* Source/WebCore/rendering/CSSFilterRenderer.h:
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerWithEffects):
(WebCore::RenderLayer::applyFilters):
(WebCore::RenderLayer::paintLayerContents):
* Source/WebCore/rendering/RenderLayer.h:
* Source/WebCore/rendering/RenderLayerFilters.cpp:
(WebCore::RenderLayerFilters::beginFilterEffect):
* Source/WebCore/rendering/RenderLayerFilters.h:
* Source/WebCore/rendering/RenderLayerSVGAdditions.cpp:
(WebCore::RenderLayer::shouldFailedFilterProduceTransparentBlackForSVG const):
(WebCore::RenderLayer::hasFailedFilterForSVG const):
(WebCore::RenderLayer::paintChildrenInDOMOrderForSVG):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

8b1fc5b

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt loading 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
loading 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv loading 🛠 mac-safer-cpp
✅ 🛠 tv-sim ✅ 🧪 mac-site-isolation
✅ 🛠 watch
✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=316788

WIP.

Reviewed by NOBODY (OOPS!).

Explanation of why this fixes the bug (OOPS!).

* LayoutTests/platform/mac-tahoe-wk2-lbse-text/TestExpectations:
* Source/WebCore/platform/graphics/filters/Filter.h:
* Source/WebCore/rendering/CSSFilterRenderer.cpp:
(WebCore::CSSFilterRenderer::create):
(WebCore::createReferenceFilter):
(WebCore::CSSFilterRenderer::expandFilterRegionForSVGReferences):
(WebCore::CSSFilterRenderer::computeEnclosingFilterRegion):
* Source/WebCore/rendering/CSSFilterRenderer.h:
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerWithEffects):
(WebCore::RenderLayer::applyFilters):
(WebCore::RenderLayer::paintLayerContents):
* Source/WebCore/rendering/RenderLayer.h:
* Source/WebCore/rendering/RenderLayerFilters.cpp:
(WebCore::RenderLayerFilters::beginFilterEffect):
* Source/WebCore/rendering/RenderLayerFilters.h:
* Source/WebCore/rendering/RenderLayerSVGAdditions.cpp:
(WebCore::RenderLayer::shouldFailedFilterProduceTransparentBlackForSVG const):
(WebCore::RenderLayer::hasFailedFilterForSVG const):
(WebCore::RenderLayer::paintChildrenInDOMOrderForSVG):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
@rwlbuis rwlbuis self-assigned this Jun 10, 2026
@rwlbuis rwlbuis added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants