Commit 13d107d
authored
Fix scroll environment creation for scrolls with long filenames (#19539)
## Summary
Note: scroll == PEP 723 script
When a scroll's filename approaches the path element length limit
(conveniently 255 almost everywhere), the underlying cache entry path
which gets generated from it ends up exceeding the limit.
This PR caps it at 100.
It does mean, however, that pre-existing environments which previously
exceeded this limit will end up re-created. No clue if this would be
breaking or not. I've marked it as such for now.
## Test Plan
Added a test for this.1 parent 1cf1f10 commit 13d107d
2 files changed
Lines changed: 39 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
717 | 717 | | |
718 | 718 | | |
719 | 719 | | |
720 | | - | |
| 720 | + | |
721 | 721 | | |
722 | 722 | | |
723 | 723 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
510 | 510 | | |
511 | 511 | | |
512 | 512 | | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
513 | 551 | | |
514 | 552 | | |
515 | 553 | | |
| |||
0 commit comments