Skip to content

getpeerinfo should report minping differently if there never was a ping #7837

Description

@laanwj

See discussion in #6636.
Currently, an implementation detail leaks here:

"minping": 9223372036854.775,

This is std::numeric_limits<int64_t>::max() milliseconds, or approximately 300,000 years. What we really want to communicate here is that the information is missing. So it would be better to report it as null.

"minping": null,

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions