release: Prepare for 0.3.1#1266
Conversation
c708dbf to
980907e
Compare
980907e to
00f3908
Compare
| # interface and therefore only increase the revision. | ||
| define(_LIB_VERSION_CURRENT, 2) | ||
| define(_LIB_VERSION_REVISION, 1) | ||
| define(_LIB_VERSION_REVISION, 2) |
There was a problem hiding this comment.
Why increase the lib version?
There was a problem hiding this comment.
From the linked libtool documentation:
- If the library source code has changed at all since the last update, then increment revision (‘c:r:a’ becomes ‘c:r+1:a’).
- If any interfaces have been added, removed, or changed since the last update, increment current, and set revision to 0.
- If any interfaces have been added since the last public release, then increment age.
- If any interfaces have been removed or changed since the last public release, then set age to 0.
I believe only the first rule applies here, so incrementing revision and not changing anything else seems correct to me.
There was a problem hiding this comment.
Maybe I'm missing something obvious, but this library version was never released. I'm not sure why we would treat the library version different to the package version in that regard. The lib version was incremented in #1228 at the same time when the package version was updated to 0.3.1. We do this so that master has a different version than the previous release.
There was a problem hiding this comment.
Oh, I didn't know that we had already increased it. We should clarify this in the release process...
|
ACK 00f3908 |
Co-authored-by: Pieter Wuille <pieter@wuille.net>
00f3908 to
b504f5d
Compare
|
forced-push to rebase on master, just to make sure |
b504f5d to
898e1c6
Compare
|
ACK 898e1c6 |
|
Let's maybe wait for CI. |
|
see also #1268 (comment), please. I assume it's okay to merge this PR here without the "[Unreleased]" section, but I can add it if you insist, of course. |
|
FWIW, here is an ABI compatibility report created with ABI Compliance Checker. |
No description provided.