Skip to content

Commit fa5605f

Browse files
ahorowitz123claudemrscobbler
authored
revert(deps): pdfjs-dist back to 4.3.136 (#1697)
Revert the pdfjs-dist 6.0.227 bump (#1666) while v6 regressions are investigated. Restores engines.node >=20.0.0 (the bump only existed to satisfy pdfjs 6) and removes the annotationLayer z-index workaround from #1694, which compensated for v6's earlier page-layer insertion and is unnecessary on v4. Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Sophia <1317004+mrscobbler@users.noreply.github.com>
1 parent 21f3c08 commit fa5605f

3 files changed

Lines changed: 240 additions & 101 deletions

File tree

package.json

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,14 @@
1919
"./styles.css": "./dist/lib/index.css",
2020
"./package.json": "./package.json"
2121
},
22-
"files": [
23-
"dist/lib"
24-
],
25-
"sideEffects": [
26-
"*.css",
27-
"*.scss"
28-
],
22+
"files": ["dist/lib"],
23+
"sideEffects": ["*.css", "*.scss"],
2924
"publishConfig": {
3025
"access": "public"
3126
},
3227
"dependencies": {
3328
"axios": "^0.24.0",
34-
"pdfjs-dist": "6.0.227"
29+
"pdfjs-dist": "4.3.136"
3530
},
3631
"peerDependencies": {
3732
"@box/blueprint-web": "^14.32.1",
@@ -137,7 +132,7 @@
137132
"webpack-dev-server": "^5.2.4"
138133
},
139134
"engines": {
140-
"node": ">=22.13.0",
135+
"node": ">=20.0.0",
141136
"yarn": ">=1.19.x"
142137
},
143138
"scripts": {

src/lib/viewers/doc/_docBase.scss

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -363,12 +363,6 @@ $thumbnail-sidebar-width: 191px; // Extra pixel to account for sidebar border
363363
}
364364

365365
.annotationLayer {
366-
// pdf.js 6 inserts its layers before the box-annotations layers, so the
367-
// region creation overlay (pointer-events: auto) paints above the link
368-
// annotations and swallows their clicks. Lift the annotation layer above
369-
// the overlay but below the region/highlight targets (z-index: 3).
370-
z-index: 2;
371-
372366
h1,
373367
h2,
374368
h3,

0 commit comments

Comments
 (0)