Summary

Add and expand unit tests across three domains: controller event predicates (48 specs), runtime feature gate detection (38 specs), and cloudflared builder gap coverage (90 specs). Combined: 176 new specs.

CEL validation coverage (109 specs) split to #40.

Context

These three domains share similar characteristics: moderate complexity, limited scope per domain, and existing test infrastructure in some cases. Bundling them into one issue avoids issue sprawl while keeping work parallelizable within the issue.

Scope

Predicates (48 specs)

Test all 4 custom predicates across 4 event types (Create, Update, Delete, Generic):

Also tests unexported helper cfgateAnnotationsChanged.

Requires controller-runtime event types and cfgate API types.

File: internal/controller/predicates_test.go (new)

Feature Detection (38 specs)

Test DetectFeatures() with mock discovery.DiscoveryInterface:

File: internal/controller/features/detection_test.go (new)

Builder Gap Coverage (90 specs)

Extend existing builder tests to cover untested functions:

Files: internal/cloudflared/configmap_test.go, internal/cloudflared/deployment_test.go (extend existing)

References

• Design docs: ~/.atlas/integrator/analysis/cfgate/t1-support-layer-design-2026-03-13.md, t1-builders-validation-design-2026-03-13.md
• CEL split: Test: Expand CEL validation marker coverage #40

Acceptance Criteria

• All 4 custom predicates tested across all event types
• Feature detection tested with mock discovery
• Builder gap functions tested
• All tests pass via go test ./internal/...