Make CSerAction's ForRead() constexpr

sipa · sipa · commit a2929a26f5cf · 2016-11-07T13:56:27.000-08:00
The CSerAction's ForRead() method does not depend on any runtime
data, so guarantee that requests to it can be optimized out by
making it constexpr.

Suggested by Cory Fields.
diff --git a/src/serialize.h b/src/serialize.h
@@ -773,11 +773,11 @@ void Unserialize(Stream& is, std::set<K, Pred, A>& m)
  */
 struct CSerActionSerialize
 {
-    bool ForRead() const { return false; }
+    constexpr bool ForRead() const { return false; }
 };
 struct CSerActionUnserialize
 {
-    bool ForRead() const { return true; }
+    constexpr bool ForRead() const { return true; }
 };
 
 template<typename Stream, typename T>

Original file line number	Diff line number	Diff line change
`@@ -773,11 +773,11 @@ void Unserialize(Stream& is, std::set<K, Pred, A>& m)`
`773`	`773`	`*/`
`774`	`774`	`struct CSerActionSerialize`
`775`	`775`	`{`
`776`		`- bool ForRead() const { return false; }`
	`776`	`+ constexpr bool ForRead() const { return false; }`
`777`	`777`	`};`
`778`	`778`	`struct CSerActionUnserialize`
`779`	`779`	`{`
`780`		`- bool ForRead() const { return true; }`
	`780`	`+ constexpr bool ForRead() const { return true; }`
`781`	`781`	`};`
`782`	`782`
`783`	`783`	`template<typename Stream, typename T>`