fix: clean up earlier refactor issues with maxExtensionTime (#2127)

feywind · web-flow · commit c22471de60c6 · 2026-02-11T13:03:34.000-05:00
diff --git a/src/lease-manager.ts b/src/lease-manager.ts
@@ -51,8 +51,6 @@ export interface FlowControlOptions {
  * @property {number} [maxBytes=104857600] The desired amount of memory to
  *     allow message data to consume. (Default: 100MB) It's possible that this
  *     value will be exceeded, since messages are received in batches.
- * @property {number} [maxExtensionMinutes=60] The maximum duration (in minutes)
- *     to extend the message deadline before redelivering.
  * @property {number} [maxMessages=1000] The desired number of messages to allow
  *     in memory before pausing the message stream. Unless allowExcessMessages
  *     is set to false, it is very likely that this value will be exceeded since
diff --git a/src/subscriber.ts b/src/subscriber.ts
@@ -1231,6 +1231,10 @@ export class Subscriber extends EventEmitter {
       );
     }
 
+    if (this._options.maxExtensionTime) {
+      this.maxExtensionTime = this._options.maxExtensionTime;
+    }
+
     if (this._inventory) {
       this._inventory.setOptions(this._options.flowControl!);
     }
diff --git a/test/subscriber.ts b/test/subscriber.ts
@@ -1108,6 +1108,17 @@ describe('Subscriber', () => {
 
       assert.strictEqual(stream.options.maxStreams, maxMessages);
     });
+
+    it('should pass through the max extension time', () => {
+      const maxExtensionTime = Duration.from({seconds: 1232});
+      subscriber.setOptions({
+        maxExtensionTime,
+      });
+      assert.strictEqual(
+        subscriber.maxExtensionTime.seconds,
+        maxExtensionTime.seconds,
+      );
+    });
   });
 
   describe('OpenTelemetry tracing', () => {

Original file line number	Diff line number	Diff line change
`@@ -1231,6 +1231,10 @@ export class Subscriber extends EventEmitter {`
`1231`	`1231`	`);`
`1232`	`1232`	`}`
`1233`	`1233`
	`1234`	`+ if (this._options.maxExtensionTime) {`
	`1235`	`+ this.maxExtensionTime = this._options.maxExtensionTime;`
	`1236`	`+ }`
	`1237`	`+`
`1234`	`1238`	`if (this._inventory) {`
`1235`	`1239`	`this._inventory.setOptions(this._options.flowControl!);`
`1236`	`1240`	`}`