Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

feat: add exactly once delivery flag#1487

Merged
feywind merged 7 commits into
mainfrom
owl-bot-bf34f5ea-4a0a-4412-b431-76abec1c6c4d
Feb 16, 2022
Merged

feat: add exactly once delivery flag#1487
feywind merged 7 commits into
mainfrom
owl-bot-bf34f5ea-4a0a-4412-b431-76abec1c6c4d

Conversation

@gcf-owl-bot

@gcf-owl-bot gcf-owl-bot Bot commented Feb 4, 2022

Copy link
Copy Markdown
Contributor
  • Regenerate this pull request now.

Merge branch 'owl-bot-bf34f5ea-4a0a-4412-b431-76abec1c6c4d' of https://github.com/googleapis/nodejs-pubsub into owl-bot-bf34f5ea-4a0a-4412-b431-76abec1c6c4d

🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'owl-bot-bf34f5ea-4a0a-4412-b431-76abec1c6c4d' of https://github.com/googleapis/nodejs-pubsub into owl-bot-bf34f5ea-4a0a-4412-b431-76abec1c6c4d

🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'main' into owl-bot-bf34f5ea-4a0a-4412-b431-76abec1c6c4d
🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

feat: add exactly once delivery flag

PiperOrigin-RevId: 426415626

Source-Link: googleapis/googleapis@1f707ab

Source-Link: https://github.com/googleapis/googleapis-gen/commit/2baebc579ed42c4d17883a14eca64411f69dcc87
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmJhZWJjNTc5ZWQ0MmM0ZDE3ODgzYTE0ZWNhNjQ0MTFmNjlkY2M4NyJ9

PiperOrigin-RevId: 426415626

Source-Link: googleapis/googleapis@1f707ab

Source-Link: googleapis/googleapis-gen@2baebc5
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmJhZWJjNTc5ZWQ0MmM0ZDE3ODgzYTE0ZWNhNjQ0MTFmNjlkY2M4NyJ9
@gcf-owl-bot
gcf-owl-bot Bot requested review from a team February 4, 2022 17:51
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 4, 2022
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Feb 4, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 4, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 4, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2022
@anguillanneuf
anguillanneuf requested a review from feywind February 7, 2022 19:22

@hongalex hongalex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, we should not merge this yet.

@feywind feywind left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feywind

feywind commented Feb 10, 2022

Copy link
Copy Markdown
Collaborator

@hongalex Why no merging yet?

@hongalex

Copy link
Copy Markdown
Member

@feywind actually we can merge now

@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 10, 2022
@feywind feywind added owlbot:run Add this label to trigger the Owlbot post processor. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 10, 2022
@feywind feywind added the automerge Merge the pull request once unit tests and other checks pass. label Feb 10, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 10, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 10, 2022
@feywind

feywind commented Feb 10, 2022

Copy link
Copy Markdown
Collaborator

I see, at closer examination, this is a different set of typing breakages. :| I'll have to look at this next week.

@gcf-merge-on-green

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 11, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 16, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2022
@feywind feywind added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 16, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2022
@feywind
feywind merged commit 330061c into main Feb 16, 2022
@feywind
feywind deleted the owl-bot-bf34f5ea-4a0a-4412-b431-76abec1c6c4d branch February 16, 2022 17:30
gcf-merge-on-green Bot pushed a commit that referenced this pull request Feb 16, 2022
🤖 I have created a release *beep* *boop*
---


## [2.19.0](v2.18.5...v2.19.0) (2022-02-16)


### Features

* add exactly once delivery flag ([#1487](#1487)) ([330061c](330061c))


### Bug Fixes

* **deps:** update dependency google-gax to v2.29.5 ([#1474](#1474)) ([f855db3](f855db3))
* **deps:** update dependency google-gax to v2.29.6 ([#1489](#1489)) ([62aba28](62aba28))
* removing misspelled field, add correctly spelled field 🦉 Updates from OwlBot ([#1490](#1490)) ([afb9cfe](afb9cfe))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
GautamSharda pushed a commit to googleapis/google-cloud-node that referenced this pull request Mar 11, 2026
🤖 I have created a release *beep* *boop*
---


## [2.19.0](googleapis/nodejs-pubsub@v2.18.5...v2.19.0) (2022-02-16)


### Features

* add exactly once delivery flag ([#1487](googleapis/nodejs-pubsub#1487)) ([330061c](googleapis/nodejs-pubsub@330061c))


### Bug Fixes

* **deps:** update dependency google-gax to v2.29.5 ([#1474](googleapis/nodejs-pubsub#1474)) ([f855db3](googleapis/nodejs-pubsub@f855db3))
* **deps:** update dependency google-gax to v2.29.6 ([#1489](googleapis/nodejs-pubsub#1489)) ([62aba28](googleapis/nodejs-pubsub@62aba28))
* removing misspelled field, add correctly spelled field 🦉 Updates from OwlBot ([#1490](googleapis/nodejs-pubsub#1490)) ([afb9cfe](googleapis/nodejs-pubsub@afb9cfe))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. owl-bot-copy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants