This is a follow-up issue for #219.
Description
The PR #224 for the issue #219 did not solve the requirement mentioned the issue.
The PR implemented a possibility to process equalities so that special characters cannot only be replaced in differing parts but also in equal parts.
However, the PR explicitly omitted to apply the equalityProcessor when using showInlineDiffs=false. The PR therefore does not provide a solution for the example provided in #219.
With this issue, I would like to extend the changes of #224 by providing a solution for the inline diffing mode as well.
Solution Approach
IMHO, the current behaviour of PR #224 is not fully consistent. As far as I understand, the library mainly offers lineNormalizer, processDiffs and now processEqualities in order to deal with escaping characters and text sequences. Explicitly excluding the processEqualities for inline diffing (while processDiffs is applied for inline diffing) is not really consistent. Therefore, I would propose to change the current behaviour by applying processEqualities for inline diffing as well.
@wumpz: How shall I implement a new PR? Shall I change the behaviour of the PR #224 by applying the equalityProcessor for inline diffs as well or shall I add yet another processor (something like an inlineEqualityProcessor) to fulfil the original requirement?
This is a follow-up issue for #219.
Description
The PR #224 for the issue #219 did not solve the requirement mentioned the issue.
The PR implemented a possibility to process equalities so that special characters cannot only be replaced in differing parts but also in equal parts.
However, the PR explicitly omitted to apply the
equalityProcessorwhen usingshowInlineDiffs=false. The PR therefore does not provide a solution for the example provided in #219.With this issue, I would like to extend the changes of #224 by providing a solution for the inline diffing mode as well.
Solution Approach
IMHO, the current behaviour of PR #224 is not fully consistent. As far as I understand, the library mainly offers
lineNormalizer,processDiffsand nowprocessEqualitiesin order to deal with escaping characters and text sequences. Explicitly excluding theprocessEqualitiesfor inline diffing (while processDiffs is applied for inline diffing) is not really consistent. Therefore, I would propose to change the current behaviour by applyingprocessEqualitiesfor inline diffing as well.@wumpz: How shall I implement a new PR? Shall I change the behaviour of the PR #224 by applying the
equalityProcessorfor inline diffs as well or shall I add yet another processor (something like an inlineEqualityProcessor) to fulfil the original requirement?