url: verify domain is not empty after "ToASCII"

targos · joesepi · commit 081441a8be85 · 2020-10-22T18:30:31.000-04:00
Port of whatwg/url#497 PR-URL: nodejs#33770 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -779,6 +779,8 @@ bool ToASCII(const std::string& input, std::string* output) {
   MaybeStackBuffer<char> buf;
   if (i18n::ToASCII(&buf, input.c_str(), input.length()) < 0)
     return false;
+  if (buf.length() == 0)
+    return false;
   output->assign(*buf, buf.length());
   return true;
 }

Original file line number	Diff line number	Diff line change
`@@ -779,6 +779,8 @@ bool ToASCII(const std::string& input, std::string* output) {`
`779`	`779`	`MaybeStackBuffer<char> buf;`
`780`	`780`	`if (i18n::ToASCII(&buf, input.c_str(), input.length()) < 0)`
`781`	`781`	`return false;`
	`782`	`+ if (buf.length() == 0)`
	`783`	`+ return false;`
`782`	`784`	`output->assign(*buf, buf.length());`
`783`	`785`	`return true;`
`784`	`786`	`}`