mentioned in: bitcoin#35118
bitcoin#35118 (comment)
"I believe you are speaking about the first commit that removes the ENABLE_IPC flag
The expectation noted in that PR was that it would need to go away once IPC fuzzing exists bitcoin#33235 (comment)
This should not force IPC on in environments that already explicitly disable it. For example, current oss-fuzz builds Bitcoin Core with NO-IPC=1 as seen here, and the generated depends toolchain will set ENABLE_IPC=OFF in that case. So oss-fuzz should continue to build without capnp
If we want to get this target running in oss-fuzz, we need a follow-up oss-fuzz change to stop using NO_IPC=1. This PR just prevents BUILD_FOR_FUZZING from unconditionally overriding a user provided IPC setting." - enirox001
mentioned in: bitcoin#35118
bitcoin#35118 (comment)
"I believe you are speaking about the first commit that removes the
ENABLE_IPCflagThe expectation noted in that PR was that it would need to go away once IPC fuzzing exists bitcoin#33235 (comment)
This should not force IPC on in environments that already explicitly disable it. For example, current oss-fuzz builds Bitcoin Core with
NO-IPC=1as seen here, and the generated depends toolchain will setENABLE_IPC=OFFin that case. So oss-fuzz should continue to build without capnpIf we want to get this target running in oss-fuzz, we need a follow-up oss-fuzz change to stop using
NO_IPC=1. This PR just preventsBUILD_FOR_FUZZINGfrom unconditionally overriding a user provided IPC setting." - enirox001