Fix qf_list

klen · klen · commit e54d6e651d29 · 2012-03-01T17:19:38.000+04:00
diff --git a/autoload/pymode/lint.vim b/autoload/pymode/lint.vim
@@ -4,25 +4,26 @@ function! pymode#lint#Check()
         try
             write
         catch /E212/
-            echohl Error | echo "File modified and I can't save it. PyLint cancel." | echohl None
+            echohl Error | echo "File modified and I can't save it. Cancel code checking." | echohl None
             return 0
         endtry
     endif	
 
     py check_file()
 
-    if len(b:qf_list) || (exists('b:errors') && len(b:errors))
+    if g:qf_list != b:qf_list
 
         call setqflist(b:qf_list, 'r')
 
+        let g:qf_list = b:qf_list
+
         if g:pymode_lint_cwindow
             call pymode#QuickfixOpen(0, g:pymode_lint_hold, g:pymode_lint_maxheight, g:pymode_lint_minheight, g:pymode_lint_jump)
         endif
 
     endif
 
     if g:pymode_lint_message
-        let b:errors = {}
         for v in b:qf_list
             let b:errors[v['lnum']] = v['text']
         endfor
@@ -35,21 +36,25 @@ function! pymode#lint#Check()
 
 endfunction
 
+
 fun! pymode#lint#Toggle() "{{{
     let g:pymode_lint = g:pymode_lint ? 0 : 1
     call pymode#lint#toggle_win(g:pymode_lint, "Pymode lint")
 endfunction "}}}
 
+
 fun! pymode#lint#ToggleWindow() "{{{
     let g:pymode_lint_cwindow = g:pymode_lint_cwindow ? 0 : 1
     call pymode#lint#toggle_win(g:pymode_lint_cwindow, "Pymode lint cwindow")
 endfunction "}}}
 
+
 fun! pymode#lint#ToggleChecker() "{{{
     let g:pymode_lint_checker = g:pymode_lint_checker == "pylint" ? "pyflakes" : "pylint"
     echomsg "Pymode lint checker: " . g:pymode_lint_checker
 endfunction "}}}
 
+
 fun! pymode#lint#toggle_win(toggle, msg) "{{{
     if a:toggle
         echomsg a:msg." enabled"
@@ -63,11 +68,10 @@ fun! pymode#lint#toggle_win(toggle, msg) "{{{
     endif
 endfunction "}}}
 
+
 fun! pymode#lint#show_errormessage() "{{{
+    if !len(b:errors) | return | endif
     let cursor = getpos(".")
-    if !pymode#Default('b:errors', {}) || !len(b:errors)
-        return
-    endif
     if has_key(b:errors, l:cursor[1])
         call pymode#WideMessage(b:errors[l:cursor[1]])
         let b:show_message = 1
diff --git a/ftplugin/python/pymode.vim b/ftplugin/python/pymode.vim
@@ -63,8 +63,7 @@ endif
 
 if g:pymode_lint
 
-    " DESC: Show message flag
-    let b:show_message = 0
+    let b:qf_list = []
 
     " DESC: Set commands
     command! -buffer -nargs=0 PyLintToggle :call pymode#lint#Toggle()
@@ -82,6 +81,13 @@ if g:pymode_lint
     endif
 
     if g:pymode_lint_message
+
+        " DESC: Show message flag
+        let b:show_message = 0
+
+        " DESC: Errors dict
+        let b:errors = {}
+
         au CursorHold <buffer> call pymode#lint#show_errormessage()
         au CursorMoved <buffer> call pymode#lint#show_errormessage()
     endif
diff --git a/plugin/pymode.vim b/plugin/pymode.vim
@@ -51,6 +51,8 @@ endif
 
 if !pymode#Default("g:pymode_lint", 1) || g:pymode_lint
 
+    let g:qf_list = []
+
     " OPTION: g:pymode_lint_write -- bool. Check code every save.
     call pymode#Default("g:pymode_lint_write", 1)
 
