Skip to content

export interceptor to type def file#3318

Merged
mcollina merged 3 commits into
nodejs:mainfrom
jakecastelli:fix-3308
Jun 12, 2024
Merged

export interceptor to type def file#3318
mcollina merged 3 commits into
nodejs:mainfrom
jakecastelli:fix-3308

Conversation

@jakecastelli

@jakecastelli jakecastelli commented Jun 10, 2024

Copy link
Copy Markdown
Member

Fixes: #3308

Status

mcollina
mcollina requested changes Jun 10, 2024
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test? we use tsd for typescript

@jakecastelli

jakecastelli commented Jun 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Sure, thanks for letting me know! Added a unit test to verify the behaviour.

Test would fail without the export to def file 
> undici@6.18.2 test:typescript
> tsd && tsc --skipLibCheck test/imports/undici-import.ts

test/imports/undici-import.ts:2:10 - error TS2614: Module '"../../"' has no exported member 'interceptors'. Did you mean to use 'import interceptors from "../../"' instead?

2 import { interceptors } from '../../'
           ~~~~~~~~~~~~


Found 1 error in test/imports/undici-import.ts:2

I added a dummy call interceptors.createRedirectInterceptor({}) just to ensure member can be accessed without any type error, not sure if its necessary.

mcollina
mcollina approved these changes Jun 10, 2024
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

metcoder95
metcoder95 reviewed Jun 11, 2024
View reviewed changes
Comment thread test/imports/undici-import.ts Outdated
@mcollina

mcollina commented Jun 11, 2024

Copy link
Copy Markdown
Member

@metcoder95 ptal

@mcollina
mcollina merged commit 1e508d7 into nodejs:main Jun 12, 2024
@btakita btakita mentioned this pull request Jun 14, 2024
Closed
@renovate renovate Bot mentioned this pull request Jun 23, 2024
Merged
This was referenced Jul 8, 2024
Open
Open
@bburns bburns mentioned this pull request Jul 12, 2024
Open
@snyk-io snyk-io Bot mentioned this pull request Jul 12, 2024
Merged
This was referenced Jul 24, 2024
Merged
Merged
Merged
@lholmquist lholmquist mentioned this pull request Aug 2, 2024
Closed
@lholmquist lholmquist mentioned this pull request Aug 7, 2024
Merged
@leonardoadame leonardoadame mentioned this pull request Aug 12, 2024
Open
@davehorton davehorton mentioned this pull request Aug 21, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Aug 21, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Aug 31, 2024
Open
@PoojaPanchal12 PoojaPanchal12 mentioned this pull request Aug 31, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Sep 10, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Sep 28, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Oct 31, 2024
Open
@dolevmiz1 dolevmiz1 mentioned this pull request Nov 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@metcoder95 metcoder95 metcoder95 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'interceptors' export doesn't work like in the docs

3 participants

@jakecastelli @mcollina @metcoder95