state-diff configs & kv functions#15903
Merged
Merged
Conversation
potuz
reviewed
Oct 21, 2025
e669e9a to
24845d5
Compare
potuz
reviewed
Oct 22, 2025
potuz
left a comment
Contributor
There was a problem hiding this comment.
Config looks good, can we add the db paths to this PR?
24845d5 to
95beb49
Compare
95beb49 to
1e4e758
Compare
1e4e758 to
ba31d61
Compare
potuz
reviewed
Nov 13, 2025
8b67f23 to
95439e7
Compare
74ba9e1 to
361f9dd
Compare
361f9dd to
1fdff87
Compare
potuz
previously approved these changes
Nov 17, 2025
prestonvanloon
requested changes
Nov 17, 2025
prestonvanloon
left a comment
Member
There was a problem hiding this comment.
Partial review.
I am concerned about under/overflow checks. I would accept this in the validation of the flag inputs, but prefer that you defensively check over/underflows in the kv package.
| ErrSlotBeforeOffset = errors.New("slot is before root offset") | ||
| ) | ||
|
|
||
| func makeKey(level int, slot uint64) []byte { |
Member
There was a problem hiding this comment.
This method name is not descriptive enough and there are many methods in this package that create keys. Please consider another name for this, perhaps mentioning state diff.
| ) | ||
|
|
||
| func makeKey(level int, slot uint64) []byte { | ||
| buf := make([]byte, 16) |
Member
There was a problem hiding this comment.
Why is the key 16 bytes? Shouldn't it be 8 bytes for a Uint64?
Contributor
Author
There was a problem hiding this comment.
it's 1 byte for the level, and 8 bytes for the slot = 9 in total. 16 is for alignment.
prestonvanloon
approved these changes
Nov 18, 2025
| type stateDiffCache struct { | ||
| sync.RWMutex | ||
| anchors []state.ReadOnlyBeaconState | ||
| offset uint64 |
Member
There was a problem hiding this comment.
You could use an atomic value here and not need a lock for the offset.
Consider this feedback optional unless you expect these methods to be a high throughput / blocking operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Note for reviewers:
Please review commit by commit.