Static analyzer for httputil.HandleError calls#16134
Merged
Merged
Conversation
httputil.HandleError calls
rkapka
commented
Dec 11, 2025
| return duties, vals, nil | ||
| } | ||
|
|
||
| func sortProposerDuties(w http.ResponseWriter, duties []*structs.ProposerDuty) bool { |
Contributor
Author
There was a problem hiding this comment.
Calling httputil.HandleError inside of sort.Slice doesn't seem like a good idea. I think it's clearer to return a regular error from sortProposerDuties and handle the error in the caller.
terencechain
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Tooling
What does the PR do?
Every call to
httputil.HandleErrormust be followed by areturnstatement. It's easy to miss this during reviews, so having a static analyzer that enforces this will make our life easier.Acknowledgements