The external runtime is not vetted for stability yet. We should stop publishing it with our stable build

gnoff · gnoff · commit 72da631368de · 2024-04-09T10:59:08.000-07:00
diff --git a/packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js b/packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js
@@ -610,7 +610,7 @@ describe('ReactDOMFizzServer', () => {
         Array.from(container.getElementsByTagName('script')).filter(
           node => node.getAttribute('nonce') === CSPnonce,
         ).length,
-      ).toEqual(6);
+      ).toEqual(gate(f => f.enableFizzExternalRuntime) ? 6 : 5);
 
       await act(() => {
         resolve({default: Text});
diff --git a/packages/shared/ReactFeatureFlags.js b/packages/shared/ReactFeatureFlags.js
@@ -110,7 +110,7 @@ export const enableUseEffectEventHook = __EXPERIMENTAL__;
 // Test in www before enabling in open source.
 // Enables DOM-server to stream its instruction set as data-attributes
 // (handled with an MutationObserver) instead of inline-scripts
-export const enableFizzExternalRuntime = true;
+export const enableFizzExternalRuntime = __EXPERIMENTAL__;
 
 export const alwaysThrottleRetries = true;
 
diff --git a/scripts/rollup/bundles.js b/scripts/rollup/bundles.js
@@ -328,7 +328,7 @@ const bundles = [
 
   /******* React DOM Fizz Server External Runtime *******/
   {
-    bundleTypes: [BROWSER_SCRIPT],
+    bundleTypes: __EXPERIMENTAL__ ? [BROWSER_SCRIPT] : [],
     moduleType: RENDERER,
     entry: 'react-dom/unstable_server-external-runtime',
     outputPath: 'unstable_server-external-runtime.js',
diff --git a/scripts/rollup/packaging.js b/scripts/rollup/packaging.js
@@ -235,7 +235,14 @@ function filterOutEntrypoints(name) {
       // Let's remove it.
       files.splice(i, 1);
       i--;
-      unlinkSync(`build/node_modules/${name}/${filename}`);
+      try {
+        unlinkSync(`build/node_modules/${name}/${filename}`);
+      } catch (err) {
+        // If the file doesn't exist we can just move on. Otherwise throw the halt the build
+        if (err.code !== 'ENOENT') {
+          throw err;
+        }
+      }
       changed = true;
       // Remove it from the exports field too if it exists.
       if (exportsJSON) {

Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,7 @@ const bundles = [`
`328`	`328`
`329`	`329`	`/***** React DOM Fizz Server External Runtime *****/`
`330`	`330`	`{`
`331`		`- bundleTypes: [BROWSER_SCRIPT],`
	`331`	`+ bundleTypes: __EXPERIMENTAL__ ? [BROWSER_SCRIPT] : [],`
`332`	`332`	`moduleType: RENDERER,`
`333`	`333`	`entry: 'react-dom/unstable_server-external-runtime',`
`334`	`334`	`outputPath: 'unstable_server-external-runtime.js',`