Skip to content

try_par_for_each_in may have avenues for perf improvements #117169

Description

@oli-obk
          This does look at bit expensive. It's probably a good idea to measure the performance impact of it. It might be a better idea to write the error to a mutex / atomic instead.

Originally posted by @Zoxc in #116849 (comment)

Once we have enabled parallel-compiler by default, we can run multithreaded benchmarks of the current impl against an impl that instead writes to an AtomicBool (as Result<(), ErrorGuaranteed> is effectively just a bool)

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-parallel-compilerArea: parallel compilerI-slowIssue: Problems and improvements with respect to performance of generated code.S-blockedStatus: Blocked on something else such as an RFC or other implementation work.

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions