Missed an edge case for consistency. Rename slug with new names. wireservice#615

nbedi · nbedi · commit a72f0104644a · 2017-02-16T15:13:26.000-05:00
diff --git a/agate/table/rename.py b/agate/table/rename.py
@@ -42,7 +42,10 @@ def rename(self, column_names=None, row_names=None, slug_columns=False, slug_row
         column_names = column_names or self._column_names
 
         if column_names is not None:
-            column_names = utils.slugify(column_names, ensure_unique=False, **kwargs)
+            if column_names == self._column_names:
+                column_names = utils.slugify(column_names, ensure_unique=False, **kwargs)
+            else:
+                column_names = utils.slugify(column_names, ensure_unique=True, **kwargs)
 
     if slug_rows:
         row_names = row_names or self.row_names
diff --git a/tests/test_table/test_rename.py b/tests/test_table/test_rename.py
@@ -79,7 +79,7 @@ def test_rename_slugify_columns(self):
 
         self.assertColumnNames(table, ['one', 'two', 'three'])
         self.assertColumnNames(table2, ['test_koz', 'test_2', 'test_2_2'])
-        self.assertColumnNames(table3, ['test.koz', 'test.2', 'test.2_2'])
+        self.assertColumnNames(table3, ['test.koz', 'test.2', 'test.2.2'])
 
     def test_rename_slugify_rows(self):
         strings = ['Test kož', 'test 2', 'test 2']
