Skip to content

misleading error logs on Pool vardiff #1899

Description

@plebhash

if let Some(new_hashrate) = new_hashrate_opt {
if let Ok(()) = channel_state.update_channel(new_hashrate, None) {
let updated_target = channel_state.get_target();
updates.push((channel_id, updated_target.clone()));
debug!(
"Updated target for extended channel_id={channel_id} to {:?}",
updated_target
);
} else {
warn!("Failed to update extended channel {channel_id}");
}
}

if let Some(new_hashrate) = new_hashrate_opt {
if let Ok(()) = channel_state.update_channel(new_hashrate, None) {
let updated_target = channel_state.get_target();
updates.push((channel_id, updated_target.clone()));
debug!(
"Updated target for standard channel_id={channel_id} to {:?}",
updated_target
);
} else {
warn!("Failed to update standard channel {channel_id}");
}
}

on error case, the user is led to believe that there was a failure on a received UpdateChannel message, while the context is actually vardiff

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions