fix(reactivity): avoid triggering effects when set fails (#14964)

ifer47 · web-flow · commit e450973eabc0 · 2026-06-25T16:16:01.000+08:00
diff --git a/packages/reactivity/__tests__/reactive.spec.ts b/packages/reactivity/__tests__/reactive.spec.ts
@@ -138,6 +138,28 @@ describe('reactivity/reactive', () => {
     expect('foo' in original).toBe(false)
   })
 
+  test('failed set operation should not trigger effects', () => {
+    const original: any = {}
+    Object.defineProperty(original, 'foo', {
+      value: 1,
+      writable: false,
+      configurable: true,
+    })
+    const observed = reactive(original)
+    let dummy
+    let run = 0
+    effect(() => {
+      run++
+      dummy = observed.foo
+    })
+
+    expect(() => {
+      observed.foo = 2
+    }).toThrow(TypeError)
+    expect(dummy).toBe(1)
+    expect(run).toBe(1)
+  })
+
   test('original value change should reflect in observed value (Object)', () => {
     const original: any = { foo: 1 }
     const observed = reactive(original)
diff --git a/packages/reactivity/src/baseHandlers.ts b/packages/reactivity/src/baseHandlers.ts
@@ -181,7 +181,7 @@ class MutableReactiveHandler extends BaseReactiveHandler {
       isRef(target) ? target : receiver,
     )
     // don't trigger if target is something up in the prototype chain of original
-    if (target === toRaw(receiver)) {
+    if (target === toRaw(receiver) && result) {
       if (!hadKey) {
         trigger(target, TriggerOpTypes.ADD, key, value)
       } else if (hasChanged(value, oldValue)) {

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ class MutableReactiveHandler extends BaseReactiveHandler {`
`181`	`181`	`isRef(target) ? target : receiver,`
`182`	`182`	`)`
`183`	`183`	`// don't trigger if target is something up in the prototype chain of original`
`184`		`- if (target === toRaw(receiver)) {`
	`184`	`+ if (target === toRaw(receiver) && result) {`
`185`	`185`	`if (!hadKey) {`
`186`	`186`	`trigger(target, TriggerOpTypes.ADD, key, value)`
`187`	`187`	`} else if (hasChanged(value, oldValue)) {`