Add InputGroup::root#2095
Merged
Merged
Conversation
4 tasks
woodruffw
force-pushed
the
ww/ig-root
branch
2 times, most recently
from
June 13, 2026 23:23
dc51437 to
a1de44e
Compare
woodruffw
marked this pull request as ready for review
June 13, 2026 23:37
woodruffw
commented
Jun 14, 2026
woodruffw
commented
Jun 14, 2026
woodruffw
force-pushed
the
ww/ig-root
branch
3 times, most recently
from
June 16, 2026 02:03
5025838 to
b2520f6
Compare
Add InputGroup::discover_root Docs Rework sarif_path Dechaff Use sarif_path in annotations too More replacements Record changes Consolidate changelog Honor GIT_CEILING_DIRECTORIES Handle bare inputs when discovering root Push SARIF path compute up, remove prefix sarif_path -> best_relative_path Remove turbofish Cleanup Remove get_group LSP: don't bother with root discovery Simplify filters Revert "Simplify filters" This reverts commit 37cbfe2. Improve filtering some more
Member
Author
|
I don't love this, but it's better than what we had before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every input group now tracks its "root", i.e. the repository root it belongs to (if it has one). We then use this to opportunistically provide a better "SARIF path" for both the SARIF and GH annotations output formats.
WIP, not plumbed yet. The idea here is to address a class of recurring problems where users runzizmor .githubor similar and get relative paths in their outputs that they don't expect (or that their tools don't expect).TODO:
Context: #1745 #2046 #2113 and probably several others. Augments the initial fix in #1748.