Skip to content

Improve documentation of slices rules#1454

Merged
codecholeric merged 1 commit into
mainfrom
slices-documentation
May 7, 2025
Merged

Improve documentation of slices rules#1454
codecholeric merged 1 commit into
mainfrom
slices-documentation

Conversation

@hankem

@hankem hankem commented May 4, 2025

Copy link
Copy Markdown
Member

The user guide's slices documentation had a comment that didn't perfectly match the code:

// checks all subpackages of 'myapp' for cycles
SlicesRuleDefinition.slices().matching("..myapp.(**)").should().notDependOnEachOther()

In addition, the involved methods could use some more JavaDoc:

Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
@hankem hankem changed the title improve documentation of slices rules Improve documentation of slices rules May 4, 2025

@codecholeric codecholeric left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this 🙂

@codecholeric codecholeric merged commit 4b53612 into main May 7, 2025
@codecholeric codecholeric deleted the slices-documentation branch May 7, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants