[SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API#617
Conversation
|
the change is larger than what the description says... |
|
@olamy jira issue updated - any remarks to change? |
| final class SurefireDependencyResolver { | ||
| @Named | ||
| @Singleton | ||
| public class SurefireDependencyResolver { |
There was a problem hiding this comment.
ditto this is turning this class into a public API.
Do we really need to publish and support another way of resolving dependencies?
why not simply having some similar private constructor and avoid exposing something else we will have to support.
There was a problem hiding this comment.
I changed to package private.
The best way will be introduce interface for this component and move implementation to another place
but this class contains a static methods which is used in AbstractSurefireMojo.
So usage is mixed, I would not extends this PR too more.
There was a problem hiding this comment.
Thanks!
Not sure why "the best way"? do you plan to introduce alternate implementations?
so no need to introduce interface for a package private class.
…er, use Resolver API - not use org.apache.maven.artifact.repository.ArtifactRepository - use resolver API
bc0e4f7 to
415f6a3
Compare
|
Another example of insane overhead of all legacy stuff: 800 lines less! Great job @slawekjaranowski |
|
Resolve #2718 |
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,where you replace
SUREFIRE-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.