fix(dc): support updated wireshark definitions#2346
Merged
Conversation
camshaft
force-pushed
the
camshaft/dc-wireshark-update
branch
from
October 8, 2024 22:58
2eb0b6d to
bdaf6d2
Compare
camshaft
force-pushed
the
camshaft/dc-wireshark-update
branch
5 times, most recently
from
October 8, 2024 23:21
89be741 to
96e8a4e
Compare
camshaft
force-pushed
the
camshaft/dc-wireshark-update
branch
from
October 8, 2024 23:26
96e8a4e to
e91cdaa
Compare
camshaft
marked this pull request as ready for review
October 8, 2024 23:32
WesleyRosenblum
approved these changes
Oct 9, 2024
WesleyRosenblum
left a comment
Contributor
There was a problem hiding this comment.
I guess the CI is only testing on one version, right? Next time we need to update this we should probably discuss how many versions to support, I don't really like supporting versions we aren't testing
Contributor
Author
|
Yeah probably worth a revisit. At least we're all green at this point 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change makes the dc wireshark plugin compatible with wireshark 4.4. Previously it only worked with 4.2.
Testing:
The tests are now passing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.