bake: hasGitAuthTokenSecret func#550
Merged
Merged
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
commented
Jan 10, 2025
| secretEntry.src = value; | ||
| break; | ||
| case 'env': | ||
| secretEntry.env = value; |
Member
Author
There was a problem hiding this comment.
This change is an oversight and fixes an issue when parsing secrets to be aligned with buildx logic: https://github.com/docker/buildx/blob/16edf5d4aa76ef9978c06889d66249aeab5729fe/util/buildflags/secrets.go#L106
Also add tests to make sure we cover everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to what we have with build:
actions-toolkit/src/buildx/build.ts
Lines 304 to 311 in e36200f