fix(eslint-plugin): only export interfaces in index#763
Merged
Conversation
The source code does not export the `customize` function or the `configs` object. But they are exported in the types, because `export type * from '...'` exports also the declare const stuff. Instead we need to only export interfaces not declarations. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #763 +/- ##
=======================================
Coverage 75.54% 75.54%
=======================================
Files 122 122
Lines 24456 24456
Branches 4670 4670
=======================================
Hits 18476 18476
Misses 5980 5980 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The source code does not export the
customizefunction or theconfigsobject. But they are exported in the types, becauseexport type * from '...'exports also the declare const stuff.Instead we need to only export interfaces not declarations.
Linked Issues
fix #762
Additional context