Use the squash option from image configuration when building with buildx#1605
Merged
rohanKanojia merged 1 commit intoSep 20, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1605 +/- ##
============================================
+ Coverage 63.53% 63.56% +0.02%
- Complexity 2166 2168 +2
============================================
Files 170 170
Lines 9922 9924 +2
Branches 1358 1359 +1
============================================
+ Hits 6304 6308 +4
+ Misses 3087 3086 -1
+ Partials 531 530 -1
|
kevinleturc
force-pushed
the
feature-buildx-use-squash-option
branch
from
September 16, 2022 16:10
192f891 to
c20c26c
Compare
Signed-off-by: Kevin Leturc <kevinleturc@users.noreply.github.com>
kevinleturc
force-pushed
the
feature-buildx-use-squash-option
branch
from
September 17, 2022 07:21
c20c26c to
922b44a
Compare
|
Kudos, SonarCloud Quality Gate passed! |
rohanKanojia
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the image/squash option is not passed honored when having also the buildx option to build our images for multiple architecture.
There's probably others options that is not honored, I will be happy to contribute them too in another PRs.
This PR is also a way for me to have initial feedback on the format & coding style before moving forward.
Let me know if it needs anything else.