Fix license table CSS selector to apply the selected row styles#16547
Merged
jtpio merged 1 commit intoJul 3, 2024
Conversation
|
Thanks for making a pull request to jupyterlab! |
Member
|
@meeseeksdev please backport to 4.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jul 3, 2024
… the selected row styles
krassowski
pushed a commit
that referenced
this pull request
Jul 3, 2024
…ted row styles (#16550) Co-authored-by: João Palmeiro <joaommpalmeiro@gmail.com>
ImpSy
pushed a commit
to spotinst/jupyterlab
that referenced
this pull request
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! 👋
References
Closes #16542
Code changes
Standardize the license table CSS selector to
.jp-Licenses-Grid.jp-RenderedHTMLCommoninstead of just.jp-Licenses-Gridso that selected row styles are applied as expected.Note
I had to manually copy the
third-party-licenses.jsonfiles to the~/jupyterlab/dev_mode/static/folder in development mode in order to test the changes. This file is not generated in development mode as far as I noticed.User-facing changes
The text of the selected row is visible, similar to what happens in the file browser:
Backwards-incompatible changes
None, as far as I know.