Refactoring: coalesce use-*-* goals.#1202
Merged
Merged
Conversation
andrzejj0
marked this pull request as draft
December 24, 2024 11:18
andrzejj0
force-pushed
the
versions-refactor
branch
from
December 24, 2024 11:24
8f73fdf to
18c7590
Compare
andrzejj0
marked this pull request as ready for review
December 24, 2024 11:25
andrzejj0
force-pushed
the
versions-refactor
branch
from
December 24, 2024 14:50
18c7590 to
46c42c3
Compare
andrzejj0
force-pushed
the
versions-refactor
branch
from
December 24, 2024 15:12
46c42c3 to
5d6e682
Compare
slawekjaranowski
approved these changes
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to try and do something similar to what #292 was, but since the plugin has moved on, it first needs some refactoring.
This PR makes the use-*-* goals use shared codebase in order to make future refactoring simpler.