Skip to content

fix(nuxt): prefer our own builder/server deps#35029

Merged
danielroe merged 1 commit into
mainfrom
fix/route-rules-resolve-34164
May 11, 2026
Merged

fix(nuxt): prefer our own builder/server deps#35029
danielroe merged 1 commit into
mainfrom
fix/route-rules-resolve-34164

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #34164

📚 Description

we had a couple of issues, from #34164 to #33606 that were a bit misleading - the issue was that mixed nuxt dependencies were being loaded - e.g. a @nuxt/nitro-server or @nuxt/vite-builder that didn't match the installed nuxt version, and this was possible because we were directly resolving it from rootDir rather than as a dependency of nuxt.

this will still be possible for non-default builders (webpack/rspack) but for the common case, this footgun is removed.

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions Bot added 5.x 🐛 bug Something isn't working as expected labels May 11, 2026
@coderabbitai

This comment has been minimized.

@pkg-pr-new

pkg-pr-new Bot commented May 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@35029

@nuxt/nitro-server

npm i https://pkg.pr.new/@nuxt/nitro-server@35029

nuxt

npm i https://pkg.pr.new/nuxt@35029

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@35029

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@35029

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@35029

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@35029

commit: 5d8f2c5

@codspeed-hq

codspeed-hq Bot commented May 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 20 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing fix/route-rules-resolve-34164 (5d8f2c5) with main (3693175)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@danielroe danielroe merged commit 4c81e81 into main May 11, 2026
48 of 50 checks passed
@danielroe danielroe deleted the fix/route-rules-resolve-34164 branch May 11, 2026 09:46
@github-actions github-actions Bot mentioned this pull request May 11, 2026
4 tasks
@github-actions github-actions Bot mentioned this pull request May 11, 2026
@github-actions github-actions Bot mentioned this pull request May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.x 🐛 bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pre-transform error: Failed to resolve import "#build/route-rules.mjs"

1 participant