Log a warning if OTLP endpoint port is likely incorrect given the protocol#6813
Merged
jack-berg merged 1 commit intoOct 22, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6813 +/- ##
============================================
- Coverage 90.37% 90.37% -0.01%
- Complexity 6577 6584 +7
============================================
Files 731 731
Lines 19714 19722 +8
Branches 1926 1931 +5
============================================
+ Hits 17817 17824 +7
Misses 1300 1300
- Partials 597 598 +1 ☔ View full report in Codecov by Sentry. |
laurit
approved these changes
Oct 22, 2024
jaydeluca
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenTelemetry java agent switched the default OTLP protocol from
grpctohttp/protobufin the 2.0 release. This is misaligned with the autoconfigure default, which is stuck with the protocol beinggrpcuntil a major version bump, which there are no plans for.This causes confusion for users.
To relieve some of the confusion, this PR adds logging when the the endpoint port is not aligned with version of the protocol. I.e. log when port is 4318 and protocol is grpc, or when port is 43117 and protocol is http/protobuf.
Thanks to @laurit for the recommendation.