WebGL / Use only two attributes instead of four for storing the hit detection color#17031
Merged
Merged
Conversation
|
📦 Preview the website for this branch here: https://deploy-preview-17031--ol-site.netlify.app/. |
81b32fd to
150278c
Compare
This will not cause any loss in precision The UNPACK_COLOR_FN shader function was adjusted because its computation wasn't quite exact and caused errors It is also now always added to shaders in order to simplify logic (this won't have an impact if it is not used in the shader)
150278c to
a4b7f70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR packs the hit detection color in two bytes (instead of 4) in the WebGL buffers. This gives the following gain in the examples:
Gain: 24.3 %
Gain: 11.5%
Gain: 24.8%
Following suggestions by @nssang00 in #16898