Configurable NoFinalizedLocalVariables for excluding methods parameters#548
Merged
Merged
Conversation
… return statements. Modified condition on `RemoveUnneededBlock` to allow for block flattening even if it contains variable declarations as long as it also contains a return (which when combined with `RemoveUnreachableCodeVisitor` should be able to prevent issues that might crop up due to descoping the first block.
…arameters` option to be able to skip the removal of final method / lambda parameters.
timtebeek
approved these changes
May 9, 2025
timtebeek
left a comment
Member
There was a problem hiding this comment.
Thanks again! Nice to see a steady stream of improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
NoFinalizedLocalVariablesto allowfinalmethod/lambda parameters to be excluded from having theirfinaldesignation removed.finalfields declared within lambdas to have their final modifier removed in the same way they get cleaned up for regular method declarations.Checklist