Use spawn to run CLI tests#5960
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6e25acb to
80e0d6c
Compare
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#use-spawn-for-cliNotice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
This ensures that abortOnStderr works
80e0d6c to
3a53f58
Compare
Performance report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5960 +/- ##
==========================================
+ Coverage 98.56% 98.77% +0.20%
==========================================
Files 270 270
Lines 8726 8726
Branches 1504 1504
==========================================
+ Hits 8601 8619 +18
+ Misses 92 73 -19
- Partials 33 34 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR has been released as part of rollup@4.41.0. You can test it via |
This ensures that abortOnStderr works
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
The Linux and Windows CLI watch tests take very long because killing the child process does not work when using child_process.exec. It does work for .spawn, though, at least on Linux. This changes most of the tests to use spawn instead, which should also make them slightly faster as they no longer require an in-between process.