feat(FilterOk): implement DoubleEndedIterator#948
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #948 +/- ##
==========================================
+ Coverage 94.38% 94.48% +0.09%
==========================================
Files 48 49 +1
Lines 6665 7030 +365
==========================================
+ Hits 6291 6642 +351
- Misses 374 388 +14 ☔ View full report in Codecov by Sentry. |
f555d16 to
d882491
Compare
Contributor
Author
|
Added the |
Philippe-Cholet
approved these changes
May 27, 2024
Philippe-Cholet
left a comment
Member
There was a problem hiding this comment.
Good. Unless @phimuemue or @jswrenn think we should not make FilterOk double ended (and FilterMapOk), I'll merge this as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented
DoubleEndedIteratorforFilterOkRefs: #947