Skip to content

docs: improve exception matching#13407

Merged
SimenB merged 8 commits into
jestjs:mainfrom
jesusarell:patch-1
Oct 11, 2022
Merged

docs: improve exception matching#13407
SimenB merged 8 commits into
jestjs:mainfrom
jesusarell:patch-1

Conversation

@jesusarell

@jesusarell jesusarell commented Oct 8, 2022

Copy link
Copy Markdown
Contributor

Explicitly state that the string argument its checked to be contained in the error message instead of to be the error message.

Summary

Test plan

@jesusarell
Improve exception matching documentation
0f3a932 
Explicitly state that the string argument its checked to be contained in the error message instead of to be the error message.
SimenB
SimenB approved these changes Oct 8, 2022
View reviewed changes

@SimenB SimenB left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Can you update the other versions of this doc as well?

image

@facebook-github-bot

facebook-github-bot commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

Hi @jesusarell!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@jesusarell

jesusarell commented Oct 11, 2022

Copy link
Copy Markdown
Contributor Author

Done! Waiting for CLA check

@jesusarell
jesusarell requested a review from SimenB October 11, 2022 12:20
@facebook-github-bot

facebook-github-bot commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

SimenB
SimenB approved these changes Oct 11, 2022
View reviewed changes

@SimenB SimenB left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB changed the title Improve exception matching documentation docs: improve exception matching Oct 11, 2022
@SimenB
SimenB merged commit a49d2de into jestjs:main Oct 11, 2022
@ms-bot ms-bot mentioned this pull request Nov 7, 2022
Closed
@github-actions

github-actions Bot commented Nov 11, 2022

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB SimenB approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jesusarell @facebook-github-bot @SimenB